mjlshen opened a new pull request, #41175: URL: https://github.com/apache/superset/pull/41175
### SUMMARY Currently, the worker startup command runs celery without `exec`. When the shell script is the container's entrypoint, the shell stays PID 1 and celery runs as its child. Since the shell installs no handler for SIGTERM, the signal delivered on Kubernetes pod termination never reaches celery, causing it to get SIGKILLed when the grace period expires. This drops in-flight tasks and leaves the worker status as online. Adding `exec` before the celery command ensures that celery replaces the shell as PID 1, allowing it to receive and handle termination signals directly. Additionally, this adds support for overriding `lifecycle` hooks and `terminationGracePeriodSeconds` for the superset worker deployment, matching the server (supersetNode) capabilities to allow custom shutdown commands (such as celery control shutdown) and extended drain periods." ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #33513 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
