rusackas commented on PR #40885: URL: https://github.com/apache/superset/pull/40885#issuecomment-4736585140
Really nice work here, @innovark37. The build_email_attachment extraction and reusing the existing CSV fetch path for XLSX both look good. That said, it's (significantly) conflicting with master and needs a rebase. Looks like all a bunch of messages.po files got regenerated. Can you drop the per-language .po churn and just leave the source string changes? A rebase may clear some of that out, I'm not sure... Also, in email.py, `_get_xlsx_attachment_extension` falls back to .zip when the bytes aren't a valid xlsx zip. When does the XLSX export endpoint actually hand back a zip rather than a single workbook? Just want to make sure we're not covering over an error payload by renaming it .zip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
