bito-code-review[bot] commented on code in PR #37014:
URL: https://github.com/apache/superset/pull/37014#discussion_r3432198576
##########
superset/viz.py:
##########
@@ -324,6 +324,7 @@ def get_df(self, query_obj: QueryObjectDict | None = None)
-> pd.DataFrame:
timestamp_format=timestamp_format,
offset=self.datasource.offset,
time_shift=self.form_data.get("time_shift"),
+ timezone=self.datasource.get_dataset_timezone(),
Review Comment:
<!-- Bito Reply -->
The suggestion to add unit tests for the new timezone feature is
appropriate. While the user has indicated that tests were added in
`test_time_filter_timezone.py` and `test_core.py`, the reviewer's concern
highlights that the new `timezone` parameter introduces significant behavioral
changes that require dedicated validation. Ensuring these tests cover success
paths, edge cases (such as invalid timezones), and the fallback to `offset` is
consistent with best practices for new functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
