rusackas commented on PR #40275: URL: https://github.com/apache/superset/pull/40275#issuecomment-4736876087
The helpers.py change LGTM. The `pytest.ini` side just needs a rebase though... now that #40276 landed, master already has the full filterwarnings block, so this only needs to flip the `case()` line to `error:` on top of current master instead of reintroducing the whole thing (and it seems we'll want to keep select() uncommented). Once it's down to that plus the case() fix, happy to merge if CI's green. Want me to push the rebase, or would you rather take it? Also adding @betodealmeida here as a reviewer since they're the real expert on this stuff ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
