rusackas commented on PR #38309: URL: https://github.com/apache/superset/pull/38309#issuecomment-4736976482
@vikash7485 this is 381 commits behind and `get_datasets` now runs under `@handle_api_exception`, which already maps `DashboardAccessDeniedError`→403 and `DashboardNotFoundError`→404 via the `SupersetException` branch in `superset/views/error_handling.py` — so the new `except` clauses in `api.py` are dead code once you rebase. The backend suites (`test-postgres`/`test-mysql`/`test-sqlite`) and `pre-commit` are also red here, and patch coverage is 0% on those lines, so the new test isn't reaching them. Can you rebase on master and confirm what's left? My read is the real value is the warning + `UPDATING.md` note about the separate `GUEST_TOKEN_JWT_*` config — the 403 in #38185 stays a 403 either way. Converting this to draft for now while it awaits touchups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
