hjadm commented on PR #40981:
URL: https://github.com/apache/superset/pull/40981#issuecomment-4737143944
Thanks for taking a look @rusackas
this adds a way to model foreign-key relationships between datasets define
them once and reuse them for drill-down, cross-filtering, and a visual
relationship canvas (React Flow).
Full disclosure: I opened this earlier than I should have, and it's grown
into an XXL PR that mixes a few independent things (the relationship model, the
API, the frontend canvas, and a more experimental cross-database merge engine).
I've moved it to draft.
Rather than push a 62-file PR through review, I'd like to do this
design-first: I'll open a SIP to align on the data model and separately on the
cross-DB join piece, which I know is the controversial part. Then I'll split
the implementation into small, reviewable PRs. Screenshots are coming with the
first slice.
Does a SIP sound like the right path to you before any code review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
