sadpandajoe commented on code in PR #41019:
URL: https://github.com/apache/superset/pull/41019#discussion_r3432548163
##########
superset-frontend/src/SqlLab/actions/sqlLab.test.ts:
##########
@@ -1107,6 +1108,44 @@ describe('async actions', () => {
});
});
+ // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
+ describe('removeQuery', () => {
+ afterEach(() => {
+ jest.restoreAllMocks();
+ });
+
+ test('removes the deleted query from the editor queries cache', async ()
=> {
Review Comment:
We should probably try seeding a real `editorQueries` cache entry and call
`removeQuery` through the store to see what happens. We can either add another
test or just add onto this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
