rusackas commented on PR #37234: URL: https://github.com/apache/superset/pull/37234#issuecomment-4737427668
Still a useful feature, @tahvane1. My remaining worry is `SupersetOAuthView.login` copies FAB's internals wholesale, which tends to break on upgrades. Could we subclass and just override the single-provider redirect, and add a test or two? I can help with pre-commit and stuff if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
