omkarhall opened a new pull request, #41182:
URL: https://github.com/apache/superset/pull/41182

   
   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Big Number charts previously displayed No data when the metric result was a 
non-empty, non-date string value. The query result was valid, but the Big 
Number transform logic attempted to parse string metric values as dates and 
returned null when the value was not a date. This change preserves non-date 
string values instead of converting them to null, allowing Big Number to render 
valid string aggregate results.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before
   <img width="1762" height="935" alt="Screenshot 2026-06-17 at 9 14 56 PM" 
src="https://github.com/user-attachments/assets/1c1ebc10-b0c7-4401-ba3a-e8066d6ef58b";
 />
   After
   <img width="1760" height="936" alt="Screenshot 2026-06-17 at 8 26 58 PM" 
src="https://github.com/user-attachments/assets/e7800e66-0424-4538-b9c2-7e2f0dcaad75";
 />
   
   
   ### TESTING INSTRUCTIONS
   1. Start Superset locally.
   2. Create or use a dataset with a non-null VARCHAR column.
   3. Create a Big Number chart using that dataset.
   4. Set the metric to MAX(varchar_column).
   5. Run the chart and confirm the returned string value is displayed instead 
of No data.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: #41030
   - [ ] Required feature flags:
   - [X] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to