hy144328 commented on PR #39735: URL: https://github.com/apache/superset/pull/39735#issuecomment-4739368908
> Hey @hy144328 - now that #40276 is merged, a good chunk of this is already on `master` (the `select()` changes across the importers, `models.py`, the old migrations...), and #40275 covers the `case()` bits once it's rebased. So if you rebase this, I think it collapses down to mostly the version pin + requirements regen. > > I also pulled the rest of the forward-compat work that doesn't overlap with your carve-outs into #41179 - the `BaseQuery` shim, `eagerload`→`joinedload`, `VisitableType`→`TypeEngine`, the `engine.execute`/raw-SQL `text()` fixes, plus some prospective `Mapped[...]` annotations. All backward-compatible with 1.4, so it can land ahead of the bump. Between that, your carve-outs, and the pin here, I think we're basically there. > > Mind rebasing this so we can see exactly what's left? Then we can sort out whether the final pin rides this PR or the dependabot one (#40830). Thanks for driving all of this! Thanks for the feedback, @rusackas . I think this PR predates the carve-out approach. I mostly wanted to get my feet wet with the codebase. So I stopped paying attention to it, and just left it in draft mode. I am happy to create a new clean PR once the forward-compatible work is done. It will only include the salient dependency changes. Or leave it to dependabot of course. I am closing this PR for now to avoid duplicate work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
