codeant-ai-for-open-source[bot] commented on code in PR #40277:
URL: https://github.com/apache/superset/pull/40277#discussion_r3434317498
##########
superset/migrations/versions/2018-03-30_14-00_d6ffdf31bdd4_add_published_column_to_dashboards.py:
##########
@@ -33,7 +33,7 @@
def upgrade():
with op.batch_alter_table("dashboards") as batch_op:
batch_op.add_column(sa.Column("published", sa.Boolean(),
nullable=True))
- op.execute("UPDATE dashboards SET published='1'")
+ op.execute(sa.text("UPDATE dashboards SET published='1'"))
Review Comment:
**Suggestion:** Add a return type annotation to the modified migration
function so the updated function is fully typed (for example, annotate
`upgrade` with `-> None`). [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The migration file is being modified and the `upgrade` function remains
untyped, with no return annotation. This matches the custom rule requiring
newly added or modified Python functions to be fully typed when surrounding
code is changed, so the suggestion is valid.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6c1260bac1eb4d38a7c75100204970dd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6c1260bac1eb4d38a7c75100204970dd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2018-03-30_14-00_d6ffdf31bdd4_add_published_column_to_dashboards.py
**Line:** 33:37
**Comment:**
*Custom Rule: Add a return type annotation to the modified migration
function so the updated function is fully typed (for example, annotate
`upgrade` with `-> None`).
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40277&comment_hash=b1b0b0e533efe899984d3a6f5298b1ec612d1fcaf32b664e9a27ac813a8dead7&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40277&comment_hash=b1b0b0e533efe899984d3a6f5298b1ec612d1fcaf32b664e9a27ac813a8dead7&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
