codeant-ai-for-open-source[bot] commented on code in PR #41181:
URL: https://github.com/apache/superset/pull/41181#discussion_r3434624703
##########
superset-frontend/src/explore/components/SaveModal.test.tsx:
##########
@@ -615,6 +615,172 @@ test('onTabChange correctly updates selectedTab via
forceUpdate', () => {
});
});
+const ownerUser = {
+ userId: 1,
+ username: 'testuser',
+ firstName: 'Test',
+ lastName: 'User',
+ isActive: true,
+ isAnonymous: false,
+ permissions: {},
+ roles: { Alpha: [['can_write', 'Dashboard']] as [string, string][] },
+ groups: [],
+};
+
+const makeMetadataDashboard = (id: number, title: string) => ({
+ id,
+ dashboard_title: title,
+ owners: [{ id: 1, first_name: 'Test', last_name: 'User' }],
+ extra_owners: [],
+ roles: [],
+ url: `/superset/dashboard/${id}/`,
+ slug: null,
+ thumbnail_url: null,
+ published: true,
+ changed_by_name: 'Test User',
+ changed_by: { id: 1, first_name: 'Test', last_name: 'User' },
+ changed_on: '2024-01-01',
+ charts: [],
+});
+
+test('pre-populates dashboard from metadata.dashboards when dashboardId prop
is absent', async () => {
+ const dashboardId = 5;
+ const dashboardTitle = 'Chart Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [{ id: dashboardId, dashboard_title: dashboardTitle }],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+ const mockFull = makeMetadataDashboard(dashboardId, dashboardTitle);
+
+ component.loadDashboard = jest.fn().mockResolvedValue(mockFull);
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
+ component.setState = jest.fn((update: any) => {
+ stateUpdates.push(update);
+ });
+
+ try {
+ sessionStorage.clear();
+ } catch (_) {
+ // ignore
+ }
+
+ await component.componentDidMount();
+
+ expect(component.loadDashboard).toHaveBeenCalledWith(dashboardId);
+ expect(stateUpdates).toContainEqual({
+ dashboard: { label: dashboardTitle, value: dashboardId },
+ });
+ expect(component.loadTabs).toHaveBeenCalledWith(dashboardId);
+});
+
+test('skips non-editable dashboards and picks the first editable one from
metadata', async () => {
+ const editableId = 7;
+ const editableTitle = 'Editable Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [
+ { id: 6, dashboard_title: 'Not Mine' },
+ { id: editableId, dashboard_title: editableTitle },
+ ],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+
+ const notMine = makeMetadataDashboard(6, 'Not Mine');
+ notMine.owners = [{ id: 99, first_name: 'Other', last_name: 'Owner' }];
+ const editable = makeMetadataDashboard(editableId, editableTitle);
+
+ component.loadDashboard = jest
+ .fn()
+ .mockImplementation((id: number) =>
+ Promise.resolve(id === 6 ? notMine : editable),
+ );
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
Review Comment:
**Suggestion:** Replace this `any[]` declaration with a reusable typed alias
for state updates to keep test typing strict and consistent. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is another occurrence of `any[]` in the added test code, so it clearly
matches the custom rule to flag TypeScript usage of `any`.
The suggestion is directly applicable and accurate.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3f7d34392e874484ad73a5466065ecef&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3f7d34392e874484ad73a5466065ecef&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/SaveModal.test.tsx
**Line:** 726:726
**Comment:**
*Custom Rule: Replace this `any[]` declaration with a reusable typed
alias for state updates to keep test typing strict and consistent.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=c6ed9565a68a30eff3c1a6614ef610ac693e44d9a7952e33b3928c75a7278cf5&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=c6ed9565a68a30eff3c1a6614ef610ac693e44d9a7952e33b3928c75a7278cf5&reaction=dislike'>👎</a>
##########
superset-frontend/src/explore/components/SaveModal.test.tsx:
##########
@@ -615,6 +615,172 @@ test('onTabChange correctly updates selectedTab via
forceUpdate', () => {
});
});
+const ownerUser = {
+ userId: 1,
+ username: 'testuser',
+ firstName: 'Test',
+ lastName: 'User',
+ isActive: true,
+ isAnonymous: false,
+ permissions: {},
+ roles: { Alpha: [['can_write', 'Dashboard']] as [string, string][] },
+ groups: [],
+};
+
+const makeMetadataDashboard = (id: number, title: string) => ({
+ id,
+ dashboard_title: title,
+ owners: [{ id: 1, first_name: 'Test', last_name: 'User' }],
+ extra_owners: [],
+ roles: [],
+ url: `/superset/dashboard/${id}/`,
+ slug: null,
+ thumbnail_url: null,
+ published: true,
+ changed_by_name: 'Test User',
+ changed_by: { id: 1, first_name: 'Test', last_name: 'User' },
+ changed_on: '2024-01-01',
+ charts: [],
+});
+
+test('pre-populates dashboard from metadata.dashboards when dashboardId prop
is absent', async () => {
+ const dashboardId = 5;
+ const dashboardTitle = 'Chart Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [{ id: dashboardId, dashboard_title: dashboardTitle }],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+ const mockFull = makeMetadataDashboard(dashboardId, dashboardTitle);
+
+ component.loadDashboard = jest.fn().mockResolvedValue(mockFull);
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
+ component.setState = jest.fn((update: any) => {
+ stateUpdates.push(update);
+ });
+
+ try {
+ sessionStorage.clear();
+ } catch (_) {
+ // ignore
+ }
+
+ await component.componentDidMount();
+
+ expect(component.loadDashboard).toHaveBeenCalledWith(dashboardId);
+ expect(stateUpdates).toContainEqual({
+ dashboard: { label: dashboardTitle, value: dashboardId },
+ });
+ expect(component.loadTabs).toHaveBeenCalledWith(dashboardId);
+});
+
+test('skips non-editable dashboards and picks the first editable one from
metadata', async () => {
+ const editableId = 7;
+ const editableTitle = 'Editable Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [
+ { id: 6, dashboard_title: 'Not Mine' },
+ { id: editableId, dashboard_title: editableTitle },
+ ],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+
+ const notMine = makeMetadataDashboard(6, 'Not Mine');
+ notMine.owners = [{ id: 99, first_name: 'Other', last_name: 'Owner' }];
+ const editable = makeMetadataDashboard(editableId, editableTitle);
+
+ component.loadDashboard = jest
+ .fn()
+ .mockImplementation((id: number) =>
+ Promise.resolve(id === 6 ? notMine : editable),
+ );
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
+ component.setState = jest.fn((update: any) => {
Review Comment:
**Suggestion:** Type the mocked `setState` callback argument with a specific
updater type (or `Partial` state type) instead of `any`. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The modified test code uses `any` in the mocked `setState` callback
parameter, which is explicitly disallowed by the rule.
This is a genuine violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bf09c90e66f94fc69262e91dbde996ed&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bf09c90e66f94fc69262e91dbde996ed&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/SaveModal.test.tsx
**Line:** 727:727
**Comment:**
*Custom Rule: Type the mocked `setState` callback argument with a
specific updater type (or `Partial` state type) instead of `any`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=21fae5a9a503c42ccde96ffef93f77ae17f5dec5b08e8209c6f2ae43165cee4a&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=21fae5a9a503c42ccde96ffef93f77ae17f5dec5b08e8209c6f2ae43165cee4a&reaction=dislike'>👎</a>
##########
superset-frontend/src/explore/components/SaveModal.test.tsx:
##########
@@ -615,6 +615,172 @@ test('onTabChange correctly updates selectedTab via
forceUpdate', () => {
});
});
+const ownerUser = {
+ userId: 1,
+ username: 'testuser',
+ firstName: 'Test',
+ lastName: 'User',
+ isActive: true,
+ isAnonymous: false,
+ permissions: {},
+ roles: { Alpha: [['can_write', 'Dashboard']] as [string, string][] },
+ groups: [],
+};
+
+const makeMetadataDashboard = (id: number, title: string) => ({
+ id,
+ dashboard_title: title,
+ owners: [{ id: 1, first_name: 'Test', last_name: 'User' }],
+ extra_owners: [],
+ roles: [],
+ url: `/superset/dashboard/${id}/`,
+ slug: null,
+ thumbnail_url: null,
+ published: true,
+ changed_by_name: 'Test User',
+ changed_by: { id: 1, first_name: 'Test', last_name: 'User' },
+ changed_on: '2024-01-01',
+ charts: [],
+});
+
+test('pre-populates dashboard from metadata.dashboards when dashboardId prop
is absent', async () => {
+ const dashboardId = 5;
+ const dashboardTitle = 'Chart Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [{ id: dashboardId, dashboard_title: dashboardTitle }],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+ const mockFull = makeMetadataDashboard(dashboardId, dashboardTitle);
+
+ component.loadDashboard = jest.fn().mockResolvedValue(mockFull);
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
+ component.setState = jest.fn((update: any) => {
+ stateUpdates.push(update);
+ });
+
+ try {
+ sessionStorage.clear();
+ } catch (_) {
+ // ignore
+ }
+
+ await component.componentDidMount();
+
+ expect(component.loadDashboard).toHaveBeenCalledWith(dashboardId);
+ expect(stateUpdates).toContainEqual({
+ dashboard: { label: dashboardTitle, value: dashboardId },
+ });
+ expect(component.loadTabs).toHaveBeenCalledWith(dashboardId);
+});
+
+test('skips non-editable dashboards and picks the first editable one from
metadata', async () => {
+ const editableId = 7;
+ const editableTitle = 'Editable Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: null,
+ metadata: {
+ dashboards: [
+ { id: 6, dashboard_title: 'Not Mine' },
+ { id: editableId, dashboard_title: editableTitle },
+ ],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+
+ const notMine = makeMetadataDashboard(6, 'Not Mine');
+ notMine.owners = [{ id: 99, first_name: 'Other', last_name: 'Owner' }];
+ const editable = makeMetadataDashboard(editableId, editableTitle);
+
+ component.loadDashboard = jest
+ .fn()
+ .mockImplementation((id: number) =>
+ Promise.resolve(id === 6 ? notMine : editable),
+ );
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
+ component.setState = jest.fn((update: any) => {
+ stateUpdates.push(update);
+ });
+
+ try {
+ sessionStorage.clear();
+ } catch (_) {
+ // ignore
+ }
+
+ await component.componentDidMount();
+
+ expect(stateUpdates).toContainEqual({
+ dashboard: { label: editableTitle, value: editableId },
+ });
+ expect(component.loadTabs).toHaveBeenCalledWith(editableId);
+});
+
+test('does not use metadata fallback when dashboardId prop is set', async ()
=> {
+ const propDashboardId = 3;
+ const propDashboardTitle = 'Prop Dashboard';
+
+ const myProps = {
+ ...defaultProps,
+ dashboardId: propDashboardId,
+ metadata: {
+ dashboards: [{ id: 99, dashboard_title: 'Should Not Be Used' }],
+ owners: ['Test User'],
+ created_on_humanized: '2 days ago',
+ changed_on_humanized: '1 day ago',
+ },
+ user: ownerUser,
+ slice: { slice_id: 1, slice_name: 'My Chart', owners: [1] },
+ dispatch: jest.fn(),
+ addDangerToast: jest.fn(),
+ };
+
+ const component = new TestSaveModal(myProps);
+ const mockFull = makeMetadataDashboard(propDashboardId, propDashboardTitle);
+
+ component.loadDashboard = jest.fn().mockResolvedValue(mockFull);
+ component.loadTabs = jest.fn().mockResolvedValue([]);
+
+ const stateUpdates: any[] = [];
Review Comment:
**Suggestion:** Replace this `any[]` usage with a concrete typed structure
that reflects the expected dashboard selection state updates. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The final PR state includes this `any[]` declaration in newly added
TypeScript test code, so it violates the no-`any` custom rule.
The suggestion correctly identifies the issue.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=222b94054b0c4d36b286a784edb724b1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=222b94054b0c4d36b286a784edb724b1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/SaveModal.test.tsx
**Line:** 770:770
**Comment:**
*Custom Rule: Replace this `any[]` usage with a concrete typed
structure that reflects the expected dashboard selection state updates.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=f9795199f18c7a451d3162ccf0b2d59fc8c0a64530062ed5bc675221276b20de&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41181&comment_hash=f9795199f18c7a451d3162ccf0b2d59fc8c0a64530062ed5bc675221276b20de&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
