younsl commented on PR #41073:
URL: https://github.com/apache/superset/pull/41073#issuecomment-4744487061
Thanks for the thorough review, @rusackas — really appreciate it, and good
catch on the websocket gap. I've pushed an update that closes the points you
raised:
- **Websocket parity**: when `supersetWebsockets.enabled` is set, the route
now appends a rule sending `supersetWebsockets.ingress.path` (default `/ws`) to
the `{{ fullname }}-ws` service on `supersetWebsockets.service.port`, reusing
the exact same values as `ingress.yaml`. So global async queries behind a
Gateway now route correctly, matching the Ingress behavior.
- **`apiVersion` override**: added `httproute.apiVersion` (defaults to
`gateway.networking.k8s.io/v1`, override to `…/v1beta1` for older Gateway API
installs).
- **Hardcoded weight**: `weight` is now a per-rule value defaulting to `1`
(backward-compatible), leaving room for traffic splitting as you suggested.
- **Rebase**: rebased onto current `master` (chart `0.16.2` → `0.17.0`) and
regenerated the README via helm-docs.
Verified with `helm lint` and `helm template`:
- default (`httproute.enabled=false`) renders 0 HTTPRoutes
- `supersetWebsockets.enabled=true` renders the second `/ws` → `-ws` rule
- `apiVersion=…/v1beta1` override renders correctly
On the overlap with #40785 — they got there first, and I'm happy to defer to
whichever you prefer to land. One difference worth noting in case it's useful:
this version models routing as a `rules` list where each rule carries its own
`matches`/`filters`/`timeouts`, which exposes the HTTPRoute `timeouts` field
and arbitrary multi-rule setups. Glad to fold any of that into #40785 instead
if that's the cleaner path forward.
I'll also take a look at the Kubernetes operator migration docs you linked —
thanks for the pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
