rusackas commented on code in PR #40720:
URL: https://github.com/apache/superset/pull/40720#discussion_r3438750159
##########
.github/workflows/superset-e2e.yml:
##########
@@ -52,6 +52,7 @@ jobs:
if: needs.changes.outputs.python == 'true' ||
needs.changes.outputs.frontend == 'true'
# Somehow one test flakes on 24.04 for unknown reasons, this is the only
GHA left on 22.04
runs-on: ubuntu-22.04
+ if: github.event.pull_request.draft == false
Review Comment:
Two `if:` keys on the same job, so YAML only keeps the last one — that
silently drops the `changes` gate (and it's what `check-yaml` is unhappy
about). Folding them into one:
```suggestion
if: (needs.changes.outputs.python == 'true' ||
needs.changes.outputs.frontend == 'true') && github.event.pull_request.draft ==
false
# Somehow one test flakes on 24.04 for unknown reasons, this is the only
GHA left on 22.04
runs-on: ubuntu-22.04
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
