Vitor-Avila opened a new pull request, #41215: URL: https://github.com/apache/superset/pull/41215
### SUMMARY A common use case for `SQL_QUERY_MUTATOR` is to add metadata comments to a query. For example, a chart query could be: ``` sql -- chart_id: 1 -- dataset_id: 1 SELECT COUNT(*) FROM cleaned_sales_data; ``` We were re-parsing the query after the mutator with `.format()`, which would change this query to: ``` sql /* chart_id: 1 */ /* dataset_id: 1 */ SELECT COUNT(*) FROM cleaned_sales_data; ``` This breaks existing logic built externally to parse logs. Additionally, Superset should change queries as little as possible. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Create a virtual dataset with multiple top-level comments like shared above (or configure comments via `SQL_QUERY_MUTATOR`. 2. Execute a query and confirm it doesn't change the comment structure. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
