rusackas commented on PR #37280: URL: https://github.com/apache/superset/pull/37280#issuecomment-4747258107
@pachara-strike the fix reads right, but it's conflicting with `master` now — can you rebase? Also `guestTokenRefresh.test.ts` already gives you a fake-timer harness; mind adding a case that asserts `unmount()` stops the refresh from firing? That race is exactly the kind of thing that silently regresses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
