rusackas commented on PR #38266: URL: https://github.com/apache/superset/pull/38266#issuecomment-4747258293
@brenot-a the `manager.py` change looks good, but this needs a rebase to resolve conflicts. The bigger issue is the ~8k lines of regenerated `.po` files, that's almost certainly what's causing the conflicts and isn't something we want in a fix PR. Can you drop everything but the `.pot` change and your `manager.py` + test edits, and let the translation pipeline propagate the new string to the `.po` files? Should shrink this to a handful of lines and stop it from going stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
