rusackas commented on PR #38691: URL: https://github.com/apache/superset/pull/38691#issuecomment-4747848396
@ferjanin the fix is right, but two things before this can merge. First, it's conflicting with `master` now, so needs a rebase. Second, @msyavuz's nit still stands — `force = "true" if self._report_schedule.force_screenshot else "false"` already lives in `_get_url`, so computing it again in `_get_tab_url` duplicates it. It'd be worth pulling that into a shared helper. On the pylint `json-import` question, that's a separate config thing, doesn't need to block this PR in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
