rusackas commented on PR #35867: URL: https://github.com/apache/superset/pull/35867#issuecomment-4748906584
@CoderSxy no changes since my last pass, and CI's still red (`lint-frontend` + a jest shard) with the branch needing a rebase. The `AdhocFilterControl/index.jsx` `moveLabel` is still the broken one — `this.values.splice(...)` is undefined (it's `this.state.values`), and `onChange(this.state.values)` hands back the unchanged array. Can you splice a copy of `this.state.values`, `setState` it, then `onChange` that copy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
