rusackas commented on PR #38094: URL: https://github.com/apache/superset/pull/38094#issuecomment-4748909233
Thanks @lucapazz, and sorry this sat. The tricky bit is that #38579 already merged the sort fix for #37892, so what's left here is the cellValues refactor plus switching null cells from `0` to N/A. The null-display change is the real behavior shift, and it's the exact thing @msyavuz flagged earlier. @msyavuz, do you think rendering null as N/A is the behavior we want post-#38579, or should we leave it? Want your read before we layer another rework on the sorter. GitHub also shows conflicts, so this'll likely want a fresh rebase on `master` either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
