rusackas commented on PR #39918: URL: https://github.com/apache/superset/pull/39918#issuecomment-4748917589
Thanks @gfody, the schema half seems reasonable. Two things hold me up though. @Vitor-Avila and @betodealmeida raised above that DB/schema were made required on purpose so schema/DB-scoped permissions resolve correctly. That never got answered, and I don't want to quietly undo it. @betodealmeida, was the required-ness load-bearing for access control, or safe to relax? Separately, the `database_id` change looks like a no-op to me. `SqlaTable.database_id` is `nullable=False`, and in `commands/dataset/update.py` (~L132) a null `database_id` is just ignored and we fall back to the existing database. So `?? null` + `allow_none=True` can't actually clear a database, only schema, despite the title. Can we drop the `database_id` bits and scope this to schema? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
