jayvenn21 commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-4752750660
@rusackas Thanks for the feedback! It’s been a while since I touched this, so I rebased the PR on current `master`. I also revisited the implementation. Instead of registering the legacy FAB password reset views and then trying to remove/unregister them afterward, this now skips registering those views during FAB security view registration. That gets closer to the FAB config direction discussed earlier, without requiring a new FAB release/dependency bump for this PR. Here are the validation tests: - `tests/integration_tests/core_tests.py::TestCore::test_admin_only_menu_views` - `tests/integration_tests/core_tests.py::TestCore::test_legacy_fab_password_views_are_not_registered` - scoped `mypy` and `ruff` on the changed files Note: I attempted `pre-commit run --all-files`, but seems like it is currently blocked by unrelated mypy errors in `tests/unit_tests/semantic_layers/mapper_test.py`, which this PR does not modify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
