rusackas commented on PR #39708:
URL: https://github.com/apache/superset/pull/39708#issuecomment-4753118358
@ayush-sharaf these tab tests are failing.
`_merge_native_filters_into_url_params` builds plain lists (`list(p)` +
`["native_filters", ...]`), but the assertions compare against tuples like
`("standalone", "true")`, and `[..] != (..)` in Python. Locally all three fail
(`test_get_dashboard_urls_with_filters_and_tabs` plus the two new ones).
Worth noting the merge logic itself is already on `master`, so as it stands
this is really just the test coverage. If you swap the tuple expectations back
to lists I think it goes green.
I'll update the branch so we can see how CI does. Thanks in advance :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
