rusackas commented on PR #39369: URL: https://github.com/apache/superset/pull/39369#issuecomment-4753475981
Did a last pass before clearing the hold. The only thing in the repo that touches `simple-zstd` is `webpack.proxy-config.js` (the dev-server proxy, decoding zstd-encoded HTML from the backend), so this is dev tooling only and nothing that ships. The v2 break is that the synchronous `ZSTDDecompress()` is gone in favor of a promise-based `decompress()`, which is handled here now (awaited inside an async `processHTML`). I verified it end to end and @hainenber couldn't repro the navigation freeze on `npm run dev-server`. CI's green apart from the hold check itself, so I'm clearing `hold:testing!`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
