sitelight commented on PR #41125: URL: https://github.com/apache/superset/pull/41125#issuecomment-4755014315
@rusackas — I just shipped #39340 (also in `superset/sql/parse.py`) so I've been spending some time in this file. The "return user clause verbatim" fix here is exactly the strategy issue #38009 (PostgreSQL `U&'...'` Unicode escape literals being corrupted by sqlglot) suggests as Option 3. #38009 lists four affected code paths and this PR closes the `sanitize_clause` one. Do you plan to extend the same approach to `SQLStatement.format()` and `transpile_to_dialect()` in this PR, or would you prefer a separate follow-up? Happy to take the follow-up if it'd be useful — just don't want to duplicate work in flight. (Also happy to wait until this lands before opening anything, given the in-flight CHANGES_REQUESTED.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
