durgaprasadml commented on PR #41200: URL: https://github.com/apache/superset/pull/41200#issuecomment-4756867344
Thanks for the contribution. I reviewed the migration, model, export/import, and clone path changes. One question: datasets expose an extra_dict convenience property for parsed access to the JSON stored in extra. Do we anticipate needing a similar helper on Slice, or is the expectation that consumers will parse the JSON directly until API/UI support is added in a follow-up PR? Otherwise, the implementation looks straightforward and consistent with existing extra patterns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
