rusackas commented on PR #38695:
URL: https://github.com/apache/superset/pull/38695#issuecomment-4765048457
Thanks @sancho11, this is a nice idea and the label-position approach seems
right for #27553.
A couple of things before we can move on it though: GitHub shows conflicts
against `master`, so it'll need a rebase first.
Also, the diff is mostly unrelated reformatting (the `() => { }` spacing,
indentation across `transformProps`/`transformers`) goes against `prettier`
rather than with it, which will likely trip pre-commit. Can you strip it back
to just the label-position changes?
Also @yousoph @kasiazjc, @sadpandajoe mentioned we shipped something like
this before and rolled it back, and the MixedTimeseries default lands on `top`
rather than the orientation-aware `auto` everywhere else, so we should take a
closer look into whether we want that approach or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
