rusackas commented on PR #39509: URL: https://github.com/apache/superset/pull/39509#issuecomment-4765057349
@atrsa GitHub shows conflicts here, so this needs a rebase on current `master` before we can re-run CI and review properly. One thing I'd like your take on while you're revisiting it: `_fetch_samples_via_cursor` runs the normal samples payload to source `coltypes`, then does the cursor round trips on top, so every page ≥ 2 runs an extra query. The docstring already flags it as a TODO. Is the extra execution something we can avoid in this PR, or is it genuinely needed until we have an ES-type to coltype translator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
