rusackas commented on PR #41126: URL: https://github.com/apache/superset/pull/41126#issuecomment-4765186287
Trimmed the test docstring down to the assertion + a pointer to the model comment — agreed it was redundant. On M1: the model fix is deliberately the whole scope here. A defensive migration only helps `create_all`-bootstrapped Postgres/MySQL installs, and a `downgrade` can never safely recreate an unsatisfiable constraint, so it'd be a one-way drop introspected by `referred_table`. I'm leaning toward shipping the model fix alone plus an `UPDATING.md` note with the manual `DROP CONSTRAINT` per dialect, rather than a migration that mutates a constraint the canonical chain never created. @aminghadersohi does that split sit right with you, or do you feel strongly the migration belongs in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
