rusackas commented on PR #40588: URL: https://github.com/apache/superset/pull/40588#issuecomment-4765189799
@aminghadersohi thanks — really thorough. Knocked out the actionable ones: added an orphan-chart test (`model.slices` → `append_charts` → stabilization), rewrote the stale "current (broken)" comments/docstring to describe the invariant, fixed the 31-bit→32-bit label, swapped the random `uuid4()` in the range test for a static high-bits boundary UUID, renamed the regression test, and updated the title/description to `fix(...)` since the fix ships here. On the collision finding: do you think it's worth guarding in this PR? At ~2³¹ width the birthday odds only get interesting for very large dashboards, but a collision detect-and-log (or fall back to the original int) is cheap if you'd rather not leave it silent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
