bito-code-review[bot] commented on code in PR #40830:
URL: https://github.com/apache/superset/pull/40830#discussion_r3449982507
##########
superset-core/pyproject.toml:
##########
@@ -46,7 +46,7 @@ dependencies = [
"isodate>=0.7.0",
"pyarrow>=16.0.0",
"pydantic>=2.8.0",
- "sqlalchemy>=1.4.0,<2.0",
+ "sqlalchemy>=2.0.50,<3",
Review Comment:
<!-- Bito Reply -->
The reviewer's concern regarding the SQLAlchemy 2.0 migration is technically
accurate, as the transition involves significant breaking changes, including
the removal of the legacy `session.query()` API. While `session.query()` may
still function in some contexts due to compatibility shims, relying on it
during a major version upgrade is generally discouraged in favor of the
`session.execute(select(...))` pattern to ensure long-term stability and
compatibility. Addressing the dependency pinning in `pyproject.toml` is a
necessary first step, but the reviewer's suggestion to audit and migrate the
codebase's usage of legacy patterns remains a valid and recommended practice
for a complete migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
