rusackas commented on PR #40472: URL: https://github.com/apache/superset/pull/40472#issuecomment-4770438741
Thanks @shivzen-pixel, the `dropdownStyle` fix itself seems right for #40430. Two things before we can merge though: The `AsyncSelect` props in `RoleFormItems.tsx` got de-indented (props at 2-space, `/>` at column 0) and `prettier` will reject that, so CI won't go green as-is. Also the `oneLine` change in `ChartCreation/index.tsx` looks unrelated to the permissions dropdown - mind dropping it so this stays focused on the issue? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
