rusackas commented on PR #40839: URL: https://github.com/apache/superset/pull/40839#issuecomment-4770445177
@Abdulrehman-PIAIC80387 this is lookin' clean and CI's green, thanks for the careful RLS handling. One thing I want to square up before we call it a fix for #39342 though: that issue is about a single dashboard load firing one query per filter over the same heavy virtual dataset, and asks us to execute the wrapping query once and project all the columns from it. This caches per-column distinct values across requests, so the cold first load still fires N queries (each column is its own cache key). Helpful on its own, but it's a different optimization than the one described. Should we reframe this as a caching improvement and leave #39342 open, or are you planning to also tackle the single-execution path? Curious your thoughts here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
