codeant-ai-for-open-source[bot] commented on code in PR #38092: URL: https://github.com/apache/superset/pull/38092#discussion_r3454031077
########## docs/admin_docs/installation/kubernetes.mdx: ########## @@ -262,6 +262,7 @@ OAuth setup requires that the [authlib](https://authlib.org/) Python library is be done using `pip` by updating the `bootstrapScript`. See the [Dependencies](#dependencies) section for more information. +More complete examples of OAuth configuration can be found in the [Security documentation](/admin-docs/security/ouath.mdx). Review Comment: **Suggestion:** The documentation link points to `/admin-docs/security/ouath.mdx`, but the new page is `oauth.mdx`. This typo creates a broken link (404) and prevents readers from reaching the OAuth setup guide; update the target path to the correct OAuth page URL. [code quality] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Kubernetes OAuth docs link returns 404 for readers. - ⚠️ Users miss detailed OAuth and Keycloak configuration docs. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open the Kubernetes installation docs at `docs/admin_docs/installation/kubernetes.mdx` and navigate to the section around line 265 containing the sentence: `More complete examples of OAuth configuration can be found in the [Security documentation](/admin-docs/security/ouath.mdx).` 2. Note that the rendered link target is `/admin-docs/security/ouath.mdx` as specified in that markdown link at line 265. 3. Inspect the security docs directory at `docs/admin_docs/security` (see LS results), which contains `oauth.md` but no file named `ouath.*` or `ouath.mdx`, confirming that the `ouath` path does not map to any existing page. 4. Build or browse the documentation site and click the "Security documentation" link from the Kubernetes page; observe that the browser is sent to `/admin-docs/security/ouath.mdx` and receives a 404/Not Found instead of loading the existing OAuth documentation defined in `docs/admin_docs/security/oauth.md`. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e3f2a8d63f6549a9a19a0fccf64ed13a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e3f2a8d63f6549a9a19a0fccf64ed13a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/installation/kubernetes.mdx **Line:** 265:265 **Comment:** *Code Quality: The documentation link points to `/admin-docs/security/ouath.mdx`, but the new page is `oauth.mdx`. This typo creates a broken link (404) and prevents readers from reaching the OAuth setup guide; update the target path to the correct OAuth page URL. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38092&comment_hash=d301c600cd55b5862c36957db7ca5042ca2d005338902328721c5dc61feaba0d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38092&comment_hash=d301c600cd55b5862c36957db7ca5042ca2d005338902328721c5dc61feaba0d&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
