rusackas commented on PR #41155: URL: https://github.com/apache/superset/pull/41155#issuecomment-4770861651
Thanks @semohr! Always happy to see the codebase get smaller :) Confirmed useTableColumns is only referenced by itself and its own test - nothing across src/packages/plugins actually consumes it. Everything that came out with it (the FormatPicker/DataTableTemporalHeaderCell bits) was private to the hook, and the temporal "Original value / Formatted date" picker still lives over in DataTableControls.tsx, so we're not losing that behavior here - just clearing out an orphaned duplicate from an older refactor. Just updated the branch to see if we can get CI to pass... something went wrong with one of the checks previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
