rusackas commented on code in PR #38443:
URL: https://github.com/apache/superset/pull/38443#discussion_r3454170455
##########
superset/db_engine_specs/gsheets.py:
##########
@@ -365,8 +380,14 @@ def validate_parameters(
engine = create_engine(
"gsheets://",
- service_account_info=encrypted_credentials,
- subject=subject,
+ connect_args={
+ "adapter_kwargs": {
+ "gsheetsapi": {
+ "service_account_info": encrypted_credentials,
+ "subject": subject,
+ }
+ }
+ },
Review Comment:
Took a look and I don't think this one bites... shillelagh's
`get_credentials` gates on `if service_account_info:`, which is falsy for an
empty `{}`, so it falls straight through to `return None` rather than trying to
build service-account creds. An OAuth2-only validation just ends up with
`credentials=None`, same as before, so `engine.connect()` doesn't fail here.
Verified against shillelagh 1.4.3.
Same reasoning covers the sibling thread flagging the identical thing, so
not treating either as a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
