rusackas commented on PR #35143: URL: https://github.com/apache/superset/pull/35143#issuecomment-4771480729
Thanks @NewtonFernandis — the cleanup itself looks right. One snag: in the `catch` you reschedule with `getGuestTokenRefreshTiming(newGuestToken)`, but `newGuestToken` is scoped to the `try`, so it's undefined there. Mind fixing that, running pre-commit, and rebasing? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
