rusackas commented on PR #36330:
URL: https://github.com/apache/superset/pull/36330#issuecomment-4773322951
@ompharate checking back in, holler if we can help move this forward. It's
still hardcoding `color: ${theme.colorTextLabel}` on the icon in
`KebabMenuButton/index.tsx` (and the inlined `EllipsisOutlined` in
`SliceHeaderControls`). That's the exact thing that drops hover/active/disabled
inheritance, so it'd be better to let the Button drive the color.
`playwright-tests`, `playwright-tests-experimental`, and `test-storybook` are
also red on CI. Ping me when CI looks good, and we'll happily re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
