rusackas commented on PR #33720: URL: https://github.com/apache/superset/pull/33720#issuecomment-4773898708
@Quatters the `ensure_ascii=False` change seems like a good fix for the unicode display issue, but `test_position_json_emoji_is_ascii_safe_in_db` (tests/integration_tests/dashboards/test_update_emoji.py:92) asserts the opposite, that the stored string stays ASCII-safe, so it's red on test-mysql/postgres/sqlite. That test was added on purpose for the emoji-truncation bug, so we need to settle the conflict rather than just delete it. And @michael-s-molina's change request was waiting on the MySQL migration + UPDATING.md note we'd agreed to, which I don't see here yet. Is that still on your plate, or do you want a hand with the rebase to get CI re-running? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
