rusackas commented on PR #39990: URL: https://github.com/apache/superset/pull/39990#issuecomment-4774293301
@Chaithanya5gif Appreciate the effort on a native candlestick plugin. Right now lint-frontend, validate-frontend and pre-commit are all red, and there are no tests yet. Can you get CI green and add coverage? A new plugin this size will also want a thumbnail and a Storybook story before we review the UX. There are also a bunch of bot comments that need to be assessed/addressed/resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
