bito-code-review[bot] commented on PR #41297:
URL: https://github.com/apache/superset/pull/41297#issuecomment-4774332716
<!-- Bito Reply -->
The suggestion to add type annotations to the `_post_payload` helper
function is correct, as it improves code clarity and adheres to the project's
typing standards. You can resolve this by updating the function signature to
include type hints for the `**overrides` parameter and the return type, as
shown below:
```python
from typing import Any, Dict
def _post_payload(**overrides: Any) -> Dict[str, Any]:
payload = {
"name": "rule",
"filter_type": "Regular",
"tables": [1],
"roles": [1],
"clause": "client_id = 9",
}
payload.update(overrides)
return payload
```
There are no other comments on this pull request to address. Would you like
me to check for any other potential improvements in this file?
**tests/unit_tests/row_level_security/schema_test.py**
```
from typing import Any, Dict
def _post_payload(**overrides: Any) -> Dict[str, Any]:
payload = {
"name": "rule",
"filter_type": "Regular",
"tables": [1],
"roles": [1],
"clause": "client_id = 9",
}
payload.update(overrides)
return payload
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
