bito-code-review[bot] commented on PR #40032:
URL: https://github.com/apache/superset/pull/40032#issuecomment-4774439894
<!-- Bito Reply -->
The flagged issue is correct. The `getPopupContainer` logic was only applied
to the main value select, leaving the inverse selection (`exclude-select`)
using the default container, which can cause overlap issues in dashboard mode.
To resolve this, you should apply the `getSelectPopupContainer` prop to the
`exclude-select` component as well.
Here is the suggested fix for `SelectFilterPlugin.tsx`:
```tsx
<Select
className="exclude-select"
getPopupContainer={getSelectPopupContainer}
// ... other props
/>
```
I have verified this based on the provided PR diff. Would you like me to
fetch all other comments on this PR to check if there are additional issues you
would like to address?
**superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx**
```
<Select
className="exclude-select"
getPopupContainer={getSelectPopupContainer}
// ... other props
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
