rusackas commented on PR #40002: URL: https://github.com/apache/superset/pull/40002#issuecomment-4774487517
Thanks @MelikHajlawi! Filling in that placeholder text is a genuine improvement, the old README was basically useless. The one thing worth flagging (and the codeant bot actually caught this one): `t`/`tn` aren't exported from `@superset-ui/core` anymore, they moved out to `@apache-superset/core/translation`, so that import in the example would've thrown. I went ahead and pushed a fixup to point it at the right package, fix up the `makeApi`/`connection` wording, and make prettier happy (it was also missing a trailing newline). LGTM otherwise, will merge once CI's green. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
