rusackas opened a new pull request, #41302:
URL: https://github.com/apache/superset/pull/41302

   ### SUMMARY
   
   Addresses #36304. When the Superset meta database 
(`ENABLE_SUPERSET_META_DB`) joins across underlying databases, 
`SUPERSET_META_DB_LIMIT` (default 1000) is applied to each underlying table 
*before* the in-memory join runs, not to the final result. If any joined table 
has more rows than the limit, only the first `SUPERSET_META_DB_LIMIT` rows of 
that table are read, so matching rows can be silently dropped and the join can 
return incomplete or empty results with no error. The existing docs mention the 
per-table limit but don't warn that it can silently produce wrong results. This 
adds a `:::warning` admonition next to the existing `SUPERSET_META_DB_LIMIT` 
prose explaining the behavior and the workaround (raise the limit above your 
largest joined table, or set it to `None` for small tables). Docs-only; the 
underlying behavior is left for a separate fix decision, so the issue stays 
open.
   
   ### TESTING INSTRUCTIONS
   
   Docs only. No code changes.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #36304
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to