codeant-ai-for-open-source[bot] commented on code in PR #41304: URL: https://github.com/apache/superset/pull/41304#discussion_r3456332948
########## tests/unit_tests/test_init_extensions_logging.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for extension-initialization error logging.""" + +from contextlib import nullcontext +from unittest.mock import MagicMock, patch + +from superset.initialization import SupersetAppInitializer + + +def _extension_that_fails_to_init(): Review Comment: **Suggestion:** Add an explicit return type annotation to this newly added helper function so new Python code remains fully typed. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This is a newly added Python function in a new file, and it has no type hints on its signature. The custom rule requires new Python code to be fully typed, so omitting the return annotation is a real violation. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ed844cada4ef48289b99d5c729438b0b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ed844cada4ef48289b99d5c729438b0b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/test_init_extensions_logging.py **Line:** 25:25 **Comment:** *Custom Rule: Add an explicit return type annotation to this newly added helper function so new Python code remains fully typed. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41304&comment_hash=2b595c968d26e5017ae86c0340ca70526e70889058e8b482eaa90ca824d0b76b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41304&comment_hash=2b595c968d26e5017ae86c0340ca70526e70889058e8b482eaa90ca824d0b76b&reaction=dislike'>👎</a> ########## tests/unit_tests/test_init_extensions_logging.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for extension-initialization error logging.""" + +from contextlib import nullcontext +from unittest.mock import MagicMock, patch + +from superset.initialization import SupersetAppInitializer + + +def _extension_that_fails_to_init(): + extension = MagicMock() + extension.backend = None # skip the in-memory importer branch + extension.manifest.id = "acme.broken_extension" + extension.manifest.backend.entrypoint = "acme.broken:init" + return extension + + +def test_init_extensions_logs_exception_instead_of_printing(): Review Comment: **Suggestion:** Add an explicit return type annotation to this new test function so newly added Python functions are fully typed. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This newly added test function does lack a return type annotation, which matches the typing rule for new Python functions. The function does have a docstring, but that does not address the missing return type hint. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fe5c40a8a9fc40fb9f4e6c07f0e5c45a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fe5c40a8a9fc40fb9f4e6c07f0e5c45a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/test_init_extensions_logging.py **Line:** 33:33 **Comment:** *Custom Rule: Add an explicit return type annotation to this new test function so newly added Python functions are fully typed. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41304&comment_hash=e38d493866c89703761463c1cd7730effcc2126016d6cedb34d343c2bddbb3d3&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41304&comment_hash=e38d493866c89703761463c1cd7730effcc2126016d6cedb34d343c2bddbb3d3&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
