bito-code-review[bot] commented on PR #41305: URL: https://github.com/apache/superset/pull/41305#issuecomment-4774531772
<!-- Bito Reply --> The suggestion to add explicit return type annotations (`-> None`) to the new test functions is correct, as it aligns with the project's requirement for fully typed Python code. You can resolve this by updating the function definitions in `tests/unit_tests/security/guest_token_audit_test.py` as follows: ```python def test_build_guest_token_audit_payload_captures_issuance_metadata() -> None: def test_build_guest_token_audit_payload_hashes_token_and_omits_raw() -> None: def test_build_guest_token_audit_payload_omits_rls_clause_text() -> None: ``` There are no other review comments in this pull request. Would you like me to apply these changes to the test file? **tests/unit_tests/security/guest_token_audit_test.py** ``` def test_build_guest_token_audit_payload_captures_issuance_metadata() -> None: def test_build_guest_token_audit_payload_hashes_token_and_omits_raw() -> None: def test_build_guest_token_audit_payload_omits_rls_clause_text() -> None: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
