suddjian commented on issue #8351: fix saving new sql lab queries URL: https://github.com/apache/incubator-superset/pull/8351#issuecomment-538585073 @graceguo-supercat I've done some investigation, and this bug seems to be connected in some way to a larger issue where null values are being returned from the backend as `"None"`. I have pinned down exactly where it affects this part of the Saved Query feature: In the response to the request `GET savedqueryviewapi/api/get/{id}`, the `query.description` is set to `"None"`. The SaveQuery component is [being provided](https://github.com/apache/incubator-superset/blob/b0a7e48d55efe681308519ba0b4d27260ec452f2/superset/assets/src/SqlLab/components/SqlEditor.jsx#L436) with either the `query.description` or `query.title`. I'm not sure how to best deal with this problem, though I have a couple very hack-y ideas. It should probably be reported as its own bug if it isn't already, as it's probably affecting other parts of the app that should be receiving nulls.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
