sha174n commented on PR #41120: URL: https://github.com/apache/superset/pull/41120#issuecomment-4774774492
@bito-code-review on the flagged points: `lo_creat` is included in the `DISALLOWED_SQL_TABLES` defaults; the estimate path resolves the effective schema through the query-aware `get_default_schema_for_query` (now via the shared `Database.resolve_query_default_schema`, applied consistently on the executor path in de1485c8e8); and three-part (catalog.schema.table) matching is covered by `tests/unit_tests/sql/parse_tests.py::test_get_disallowed_tables` (match + catalog-mismatch cases). The `get_disallowed_tables` signatures are consistent across the statement/script/Kusto variants — the script-level wrapper is intentionally two-arg and computes the per-statement flag internally before forwarding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
