mistercrunch commented on a change in pull request #8343: Add support for Exasol
URL:
https://github.com/apache/incubator-superset/pull/8343#discussion_r331750707
##########
File path: superset/dataframe.py
##########
@@ -119,6 +119,8 @@ def __init__(self, data, cursor_description,
db_engine_spec):
}
self.df = pd.DataFrame(data, columns=column_names)
else:
+ if getattr(db_engine_spec, "odbc_row_results", None):
+ data = [[value for value in row] for row in data]
Review comment:
If something special is needed for Exasol/odbc it should be in the engine
specific module. One way would be to override `fetch_data` for Exasol.
https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs/base.py#L225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
