rusackas commented on PR #36073: URL: https://github.com/apache/superset/pull/36073#issuecomment-4775625742
Thanks @innovark37, the visibility logic itself looks right. But the `css`/`SupersetTheme` imports in `DataTable.tsx` and `SearchSelectDropdown.tsx` point at `@apache-superset/core/ui`, and that package only exports a `./theme` subpath, not `./ui`, so the build can't resolve it (that's what's reddening lint/validate/storybook here). The original `styled` import was from `@apache-superset/core/theme`. Mind switching back to that entrypoint? Also looks like @SBIN2010's note about dropping the record-count placeholder is still open... worth settling that before we re-review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
